Detect bidir 5665 v14 #11497
Closed
Detect bidir 5665 v14 #11497
+380
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
By using keywords bidir.toclient and bidir.toserver, the following keywords are forced to the direction even if they can match on both directions. Ticket: 5665
Do not require a rule to use bidir.toserver after the usage of bidir.toclient for unambiguous keywords, where the rule writer does not want to explicit the redundant direction.
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11497 +/- ##
==========================================
+ Coverage 82.56% 82.65% +0.09%
==========================================
Files 938 938
Lines 248247 248394 +147
==========================================
+ Hits 204961 205322 +361
+ Misses 43286 43072 -214
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 21544 |
jufajardini
requested changes
Jul 18, 2024
Comment on lines
+291
to
+293
| - They cannot have ``fast_pattern`` or ``prefilter`` on a keyword which is on | ||
| the direction to client only if they do have any streaming buffers for detection | ||
| on the other side. |
There was a problem hiding this comment.
This part is still difficult to know how to read, to me. What about, maybe...
Suggested change
| - They cannot have ``fast_pattern`` or ``prefilter`` on a keyword which is on | |
| the direction to client only if they do have any streaming buffers for detection | |
| on the other side. | |
| - They cannot have ``fast_pattern`` or ``prefilter`` on a keyword which is on | |
| the direction to client - only if they do have any streaming buffers for detection | |
| on the other side. |
(If that's what this means, ofc XD )
There was a problem hiding this comment.
adding an example of an impossible rule
|
To me, it looks like all the commits could be squashed, indeed. Or maybe have one for code, and one for docs... 🤔 |
|
Continued in #11528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
SV_BRANCH=OISF/suricata-verify#1922
#11323 with better doc
First version not a draft.
Should I squash all the commits together ?