next/599/20241012/v1 #11948
Merged
next/599/20241012/v1 #11948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 7166
Issue: 7165
Issue: 7165
Re-introduce support for command line argument "--napatech" Issue: 7165
Issue: 7165 Plugins can't be build using the standard autoconf/automake methods. We can get around this by creating our own Makefiles, but they're often less portable. For now, fail during ./configure instead of during compile.
Issue: 7165
Original limit was due to a specific data structure. (lifted from 96a0ffa)
Commit changes are made to avoid possible memory leaks. If the parser is initialized before configuration file checking, there was no deinit call before function return. Do check config file existance and type before YAML parser initialization, so we don't need to deinit parser before exiting the function. Bug: OISF#7302
Ticket: 3195 Also remove unused src/tests/detect-template-buffer.c Completes commit 4a7567b to remove references to template-rust
The pattern of checking the pause flag, setting to paused then waiting to unpause was done enough times to factor out into its own function. This is also needed by library users who bring their own packet acquisition threads.
TmThreadTestThreadUnPaused was only being used by TmThreadsWaitForUnpause and is still enough to just become one function.
Threads are only set to paused upon initialization and never again, we should only have to wait once, so move the wait before any loop that was waiting before. Additionally, if the thread was killed while waiting to be unpaused, don't enter the loop.
victorjulien
requested review from
jasonish,
jufajardini and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11948 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 912 910 -2
Lines 249102 249008 -94
=======================================
- Hits 206117 206043 -74
+ Misses 42985 42965 -20
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23095 |
jasonish
approved these changes
Oct 12, 2024
This was referenced Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: