-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dns dcerpc reversed v4 #12134
base: master
Are you sure you want to change the base?
Dns dcerpc reversed v4 #12134
Conversation
Several additional checks are added to the probing parser to avoid false detection of DNS as DCERPC Ticket - 7111
Protocol detection code is simplified. Removed dependency on explicit alproto constants from the common part of code that must not be aware of the each specific protocol features. Ticket - 7111
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12134 +/- ##
===========================================
+ Coverage 62.68% 79.49% +16.80%
===========================================
Files 840 909 +69
Lines 153669 257701 +104032
===========================================
+ Hits 96323 204851 +108528
+ Misses 57346 52850 -4496
Flags with carried forward coverage won't be shown. Click here to find out more. |
@ilya-bakhtin I think you need ro rebase your SV PR onto latest SV master to get CI green |
i'm sorry, my bad anyhow SV - OISF/suricata-verify#2151 |
BTW probably it would be better to return to my very first solution. |
I think the current solution is better as it solves more trouble :-) |
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7111
Describe changes:
This is a replacement of #11679
There are 2 commits.
The first one is intended to improve DCERPC UDP detection. False positives resulted in improper work of the detection framework.
The second commit simplifies the detection framework function AppLayerProtoDetectGetProto.
It previously contained a bug that combined with a false positive in DCERPC resulted in incorrect reporting of DNS flow direction.
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2151
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=