Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/689/20250114/v1 #12393

Merged
merged 2 commits into from
Jan 14, 2025
Merged

next/689/20250114/v1 #12393

merged 2 commits into from
Jan 14, 2025

Conversation

victorjulien
Copy link
Member

@AkakiAlice @victorjulien
detect: add vlan.id keyword
b1c2643 
vlan.id matches on Virtual Local Area Network IDs
It is an unsigned 16-bit integer
Valid range = [0-4095]
Supports prefiltering

Ticket: OISF#1065
@AkakiAlice @victorjulien
detect: add vlan.layers keyword
078c646 
vlan.layers matches on the number of VLAN layers per packet
It is an unsigned 8-bit integer
Valid range = [0-3]
Supports prefiltering

Ticket: OISF#1065
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.66397% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (637708a) to head (078c646).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #12393    +/-   ##
========================================
  Coverage   80.63%   80.63%            
========================================
  Files         915      917     +2     
  Lines      258440   258687   +247     
========================================
+ Hits       208401   208601   +200     
- Misses      50039    50086    +47
Flag Coverage Δ
fuzzcorpus 56.81% <13.42%> (-0.05%) ⬇️
livemode 19.39% <13.42%> (-0.01%) ⬇️
pcap 44.26% <13.42%> (-0.09%) ⬇️
suricata-verify 63.22% <78.37%> (-0.04%) ⬇️
unittests 58.51% <55.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 651 629 96.62%

Pipeline 24206

jasonish
jasonish approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging looks OK.

@victorjulien victorjulien merged commit 078c646 into OISF:master Jan 14, 2025
60 checks passed
@victorjulien victorjulien mentioned this pull request Jan 14, 2025
Closed
5 tasks
@victorjulien victorjulien deleted the next/689/20250114/v1 branch January 14, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jasonish @AkakiAlice