Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/csum: rm interaction btw stream setting/csum #12432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlucovsky
Copy link
Contributor

Issue: 7467

Stream checksum validation no longer has a side effect of setting PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7467

Describe changes:

  • During stream checksum validation checks, no longer set PKT_IGNORE_CHECKSUM

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#2241
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 7467

Stream checksum validation no longer has a side effect of setting
PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (8f6795d) to head (e4b9ca9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12432      +/-   ##
==========================================
- Coverage   80.63%   80.63%   -0.01%     
==========================================
  Files         918      920       +2     
  Lines      258696   258693       -3     
==========================================
- Hits       208598   208594       -4     
- Misses      50098    50099       +1     
Flag Coverage Δ
fuzzcorpus 56.80% <ø> (-0.01%) ⬇️
livemode 19.39% <ø> (-0.01%) ⬇️
pcap 44.28% <ø> (-0.02%) ⬇️
suricata-verify 63.26% <ø> (+0.02%) ⬆️
unittests 58.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien
Copy link
Member

I think this is a behavior change that needs to be documented in the upgrade guide.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants