flow/output: log triggered exception policies - v3 #12710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12710 +/- ##
==========================================
+ Coverage 80.71% 80.72% +0.01%
==========================================
Files 936 936
Lines 259393 259474 +81
==========================================
+ Hits 209368 209463 +95
+ Misses 50025 50011 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24952 |
To accompany the Exception Policy stats, also add information about any Exception Policy triggered and for which target to the flow log event. Task OISF#6215
ExceptionPolicy-related members added to the struct led to the need to better optimize it. Related to Task OISF#6215
The stats for exception policies are only logged/ present when any of the exception policies are enabled (which means any value other than "auto" or "ignore" in IDS mode, or "ignore" in IPS mode). This wasn't clearly stated in the docs.
jufajardini
force-pushed
the
6215-eps-output/v3
branch
from
3f31f45 to
b5a7089
Compare
|
Information: QA ran without warnings. Pipeline 24959 |
|
an alternative output proposal: {
"pkts_toserver": 18,
"pkts_toclient": 14,
"bytes_toserver": 2146,
"bytes_toclient": 7452,
"start": "2019-05-15T08:11:18.738996+0000",
"end": "2019-05-15T08:11:19.256052+0000",
"age": 1,
"state": "closed",
"reason": "shutdown",
"alerted": false,
"exception_policy": {
"triggered": [
{
"target": "stream_reassembly_memcap",
"policy": "pass_packet"
},
{
"target": "app_layer_error",
"policy": "ignore"
}
]
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (if applicable):
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/6215
Previous PR: #12700
Output sample, when policies are triggered:
{ "pkts_toserver": 18, "pkts_toclient": 14, "bytes_toserver": 2146, "bytes_toclient": 7452, "start": "2019-05-15T08:11:18.738996+0000", "end": "2019-05-15T08:11:19.256052+0000", "age": 1, "state": "closed", "reason": "shutdown", "alerted": false, "exception_policy_triggered": [ { "target": "stream_reassembly_memcap", "policy": "pass_packet" }, { "target": "app_layer_error", "policy": "ignore" } ] }Describe changes:
enum ExceptionPolicyTargetChanges in previous PR:
-- this includes some implementation changes to accommodate that
-- this includes an attempt at rearranging the Flow struct -- used pahole to check for holes and struct size. Size remains the same as before the change, from what I could compare
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2332