Applayer plugin 5053 v15.1 #12726
Closed
Applayer plugin 5053 v15.1 #12726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use generic logger callback prototype with later cast and do some other small modifications so that the plugin has less diff
so that it can be used by plugins Avoid export by cbindgen as this constant is also defined in C
including the tx parameter to the logger function
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12726 +/- ##
==========================================
+ Coverage 80.76% 80.79% +0.03%
==========================================
Files 936 936
Lines 259724 260093 +369
==========================================
+ Hits 209765 210150 +385
+ Misses 49959 49943 -16
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Ticket: 7151 Ticket: 7152 Ticket: 7154
Ticket: 7149 Ticket: 7150 Ticket: 7153
catenacyber
force-pushed
the
applayer-plugin-5053-v15.1
branch
from
8c91dcf to
58eaa4e
Compare
|
Information: QA ran without warnings. Pipeline 25008 |
jasonish
reviewed
Mar 7, 2025
| --allowlist-type 'SC.*' \ | ||
| --allowlist-function 'SC.*' \ | ||
| --allowlist-item 'SC.*' \ |
There was a problem hiding this comment.
This will actually fail on the some versions of bindgen that otherwise will work, I think the bindgen on Ubuntu 22.04 maybe?
There was a problem hiding this comment.
adding --allowlist-var 'SC.*' then
|
Continues in #12733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4102 with all 6 subtickets
Describe changes:
#12667 with
I think #12724 should come before that PR
And I think we would also want after that, another PR that splits suricata crate in 2 : like suricata-core which has 0 dependencies and can be used by plugins, and the rest of suricata