build-info: workaround special _FORTIFY_SOURCE defines #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The explanation really belongs in a code comment in this case. This is one of those things that someone might 'optimize' after looking at the code. In general, explanations should not just be in pull requests. Make them part of commit messages or code comments or both, whatever makes most sense in specific cases. Can you do a new PR with the explanation as a code comment? |
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Dec 5, 2018
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Dec 5, 2018
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Dec 5, 2018
3 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 19, 2018
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 19, 2018
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 19, 2018
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 16, 2019
catenacyber
added a commit
to catenacyber/suricata
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the issue with distributions defining _FORTIFY_SOURCE by default, like Gentoo does (#define _FORTIFY_SOURCE=((defined OPTIMIZE && OPTIMIZE > 0) ? 2 : 0)) and resolves the issue https://redmine.openinfosecfoundation.org/issues/1676