detect/pcre: Capture count validation check #5827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit corrects the validation check between the number of variables used and the number of specified capture groups.
Codecov Report
@@ Coverage Diff @@
## master #5827 +/- ##
=======================================
Coverage 72.38% 72.38%
=======================================
Files 604 604
Lines 179369 179370 +1
=======================================
+ Hits 129837 129842 +5
+ Misses 49532 49528 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Merged in #5840, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #5826
This PR fixes the validation check between the capture count in the PCRE and the number of variables to extract.
Link to redmine ticket: 4261
Describe changes:
clang-formatfixups#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: