Ossfuzz corp v7 #5837
Closed
Ossfuzz corp v7 #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so as to avoid overrecursion leading to stack exhaustion
Closed
| @@ -38,6 +38,8 @@ | |||
| #include "util-unittest.h" | |||
| #include "util-debug.h" | |||
|
|
|||
| #define MAX_ETH_OFFSET 256 | |||
There was a problem hiding this comment.
Indeed, removing in next PR
| @@ -887,6 +891,15 @@ void CaptureStatsSetup(ThreadVars *tv, CaptureStats *s); | |||
| ((p)->action |= a)); \ | |||
| } while (0) | |||
|
|
|||
| #define PKT_MAX_DECODED_LAYERS 16 | |||
|
|
|||
| #define PACKET_INCREASE_CHECK_LAYERS(p) do { \ | |||
There was a problem hiding this comment.
I think adding a macro to hides a return statement inside is not a great solution. I understand the desire to keep things tidy, but this is not the way.
Closed
|
Replaced by #5838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4125
Describe changes:
bytemathkeyword parsingDecodeEthernetandDecodeMPLSModifies #5811 by counting the total number of layers so that too much recursion can't happen anywhere (and adding a field to the structure Packet to do so)