Pcre threadsafe 4720 v3 #6429
Closed
Pcre threadsafe 4720 v3 #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that DetectPcrePayloadMatch is thread safe and does not rewrite a shared parse_regex.match structure
This was referenced Sep 30, 2021
|
Replaced by #6430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4720
Describe changes:
pcre2_match_datafor each thread to be used in ofDetectPcrePayloadMatchpcre2_match_datafor each call to pcerexform Transform (as we do not have access toDetectEngineThreadCtxin transforms)Replaces #6427 with fixing compilation and formatting check