detect-id: convert unittests to FAIL/PASS APIs #6621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #6621 +/- ##
==========================================
+ Coverage 77.05% 77.08% +0.02%
==========================================
Files 613 613
Lines 186203 186179 -24
==========================================
+ Hits 143482 143512 +30
+ Misses 42721 42667 -54
Flags with carried forward coverage won't be shown. Click here to find out more. |
jufajardini
requested changes
Nov 19, 2021
Comment on lines
-373
to
-389
| const char *sigs[3]; | ||
| sigs[0]= "alert ip any any -> any any (msg:\"Testing id 1\"; id:1234; sid:1;)"; | ||
| sigs[1]= "alert ip any any -> any any (msg:\"Testing id 2\"; id:5678; sid:2;)"; | ||
| sigs[2]= "alert ip any any -> any any (msg:\"Testing id 3\"; id:5101; sid:3;)"; | ||
|
|
||
| uint32_t sid[3] = {1, 2, 3}; | ||
|
|
||
| uint32_t results[3][3] = { | ||
| /* packet 0 match sid 1 but should not match sid 2 */ | ||
| {1, 0, 0}, | ||
| /* packet 1 should not match */ | ||
| {0, 1, 0}, | ||
| /* packet 2 should not match */ | ||
| {0, 0, 1} }; | ||
|
|
||
| result = UTHGenericTest(p, 3, sigs, sid, (uint32_t *) results, 3); | ||
|
|
There was a problem hiding this comment.
If we deleted these, we would be deleting the core of this test ;)
| /* packet 2 should not match */ | ||
| {0, 0, 1} }; | ||
|
|
||
| result = UTHGenericTest(p, 3, sigs, sid, (uint32_t *) results, 3); |
There was a problem hiding this comment.
I think a check like
FAIL_IF_NOT(UTHGenericTest(p, 3, sigs, sid, (uint32_t *) results, 3));here would work :)
3 tasks
|
Followed by: #6626 |
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 21, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 26, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 5, 2024
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 11, 2024
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 19, 2024
hadiqaalamdar
pushed a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 19, 2024
dns: add dns.rcode keyword Feature OISF#6621 It matches the rcode field in DNS It's an integer match valid ranges = 0-23 Does not support prefilter Supports flow in client direction
3 tasks
hadiqaalamdar
pushed a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 19, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an integer match valid ranges = 0-23 Does not support prefilter Supports flow in client direction
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 24, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-23] Does not support prefilter Supports flow in client direction
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 24, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-23] Does not support prefilter Supports flow in client direction
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 24, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-23] Does not support prefilter Supports flow in client direction
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Jan 25, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-23] Does not support prefilter Supports flow in both directions
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Feb 15, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-15] Does not support prefilter Supports flow in both directions
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Feb 19, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-15] Does not support prefilter Supports flow in both directions
3 tasks
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
Mar 5, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-15] Does not support prefilter Supports flow in both directions
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
Mar 5, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-15] Does not support prefilter Supports flow in both directions
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
Mar 5, 2024
Feature OISF#6621 It matches the rcode field in DNS It's an unsigned integer match valid ranges = [0-15] Does not support prefilter Supports flow in both directions
jufajardini
pushed a commit
to jufajardini/suricata
that referenced
this pull request
Mar 5, 2024
dns.rcode matches the rcode header field in DNS messages It's an unsigned integer valid ranges = [0-15] Does not support prefilter Supports matches in both flow directions Task OISF#6621
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Mar 9, 2024
dns.rcode matches the rcode header field in DNS messages It's an unsigned integer valid ranges = [0-15] Does not support prefilter Supports matches in both flow directions Task OISF#6621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4046
Ticket: #4046
Previous PR: #6619
Describe changes: