util/mime: fix integer warnings #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 4516
Closed
Codecov Report
@@ Coverage Diff @@
## master #7074 +/- ##
==========================================
+ Coverage 75.54% 78.16% +2.62%
==========================================
Files 628 628
Lines 185325 185466 +141
==========================================
+ Hits 139996 144972 +4976
+ Misses 45329 40494 -4835
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Feb 28, 2022
Merged
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 28, 2025
Expose base64 standard, and standard_no_pad encoding to Lua scripts. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 28, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 28, 2025
Create a lenient base64 decode for Lua that is indifferent to spacing and allows trailing data. Expose to Lua as "decode_lenient". Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
Expose base64 standard, and standard_no_pad encoding to Lua scripts. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Jan 30, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 10, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 10, 2025
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 13, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Feb 13, 2025
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 13, 2025
Export our base64 decoding and encoding functions to Lua. Ticket: OISF#7074
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4516
Describe changes:
-Wimplicit-int-conversionin util-decode-mime.cIt does not fix the
tolowerstuff taken care of by #7073Part of #7006 modified :
FindBuffernow takes anuint16The only problematic part is about
extract_urls_schemeswhich usesstrlenon strings coming from configuration.This length is now checked when reading the configuration in
SMTPConfigureThe other uses of
FindBufferuse fixed strings (whose length fits in a u8) or strings whose length is checked cfBOUNDARY_BUF