Next/50x/20220531/v2 #7453
Merged
Next/50x/20220531/v2 #7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GCC 12 the memcmp code using `_mm_blendv_epi8` failed to work. Inspection of the disassembled objects suggests that it simply omits the instruction on systems that are not AVX512 capable. On AVX512 it does replace it with VPCMPB logic that appears to work. Luckily our use of blend is actually uncessary. A simple AND is sufficient. Bug: OISF#5312. (cherry picked from commit 87c5d69)
cppcheck:
src/util-memcmp.h:281:18: warning: Identical condition 'len-offset<16', second condition is always false [identicalConditionAfterEarlyExit]
if (diff < 16) {
^
src/util-memcmp.h:280:24: note: 'diff' is assigned value 'len-offset' here.
int diff = len - offset;
^
src/util-memcmp.h:269:33: note: If condition 'len-offset<16' is true, the function will return/exit
if (likely(len - offset < 16)) {
^
src/util-memcmp.h:281:18: note: Testing identical condition 'len-offset<16'
if (diff < 16) {
^
src/util-memcmp.h:344:18: warning: Identical condition 'len-offset<16', second condition is always false [identicalConditionAfterEarlyExit]
if (diff < 16) {
^
src/util-memcmp.h:343:24: note: 'diff' is assigned value 'len-offset' here.
int diff = len - offset;
^
src/util-memcmp.h:318:33: note: If condition 'len-offset<16' is true, the function will return/exit
if (likely(len - offset < 16)) {
^
src/util-memcmp.h:344:18: note: Testing identical condition 'len-offset<16'
if (diff < 16) {
^
src/util-memcmp.h:171:18: warning: Identical condition 'len-offset<16', second condition is always false [identicalConditionAfterEarlyExit]
if (diff < 16) {
^
src/util-memcmp.h:170:24: note: 'diff' is assigned value 'len-offset' here.
int diff = len - offset;
^
src/util-memcmp.h:159:33: note: If condition 'len-offset<16' is true, the function will return/exit
if (likely(len - offset < 16)) {
^
src/util-memcmp.h:171:18: note: Testing identical condition 'len-offset<16'
if (diff < 16) {
^
src/util-memcmp.h:233:18: warning: Identical condition 'len-offset<16', second condition is always false [identicalConditionAfterEarlyExit]
if (diff < 16) {
^
src/util-memcmp.h:232:24: note: 'diff' is assigned value 'len-offset' here.
int diff = len - offset;
^
src/util-memcmp.h:208:33: note: If condition 'len-offset<16' is true, the function will return/exit
if (likely(len - offset < 16)) {
^
src/util-memcmp.h:233:18: note: Testing identical condition 'len-offset<16'
if (diff < 16) {
^
(cherry picked from commit ca97ed4)
(cherry picked from commit 0fc7ba4)
(cherry picked from commit f047998)
(cherry picked from commit 394356f)
(cherry picked from commit 5ec6f3b)
Rust generates warnings that are treated as errors for documentation blocks before `extern` blocks. (cherry picked from commit 6ccc01a)
|
ERROR: ERROR: QA failed on tlpw1_files_sha256. ERROR: QA failed on tlpr1_alerts_cmp. Pipeline 7615 |
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Dec 23, 2024
ldap.request.operation matches on Lightweight Directory Access Protocol request operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
5 tasks
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 6, 2025
ldap.request.operation matches on Lightweight Directory Access Protocol request operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 6, 2025
ldap.request.operation matches on Lightweight Directory Access Protocol request operations ldap.responses.operation matches on Lightweight Directory Access Protocol response operations Both are unsigned 8-bit integer Don't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 17, 2025
ldap.request.operation matches on Lightweight Directory Access Protocol request operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 17, 2025
ldap.responses.operation matches on Lightweight Directory Access Protocol response operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 17, 2025
ldap.responses.count matches on the number of LDAP responses It is an unsigned 32-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 20, 2025
ldap.request.operation matches on Lightweight Directory Access Protocol request operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 20, 2025
ldap.responses.operation matches on Lightweight Directory Access Protocol response operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
added a commit
to AkakiAlice/suricata
that referenced
this pull request
Jan 20, 2025
ldap.responses.count matches on the number of LDAP responses It is an unsigned 32-bit integer Doesn't support prefiltering Ticket: OISF#7453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7449 with a rustdoc fixup