Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more user-friendly with non-existing user v2 #9657

Closed
wants to merge 2 commits into from

Conversation

lukashino
Copy link
Contributor

Follow-up of #9628

Redmine ticket:

https://redmine.openinfosecfoundation.org/issues/6278

Describe changes:

  • edit the commit message - changed assert to FatalError
  • edit error message to hint about options

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=pr/1431
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Lukas Sismis added 2 commits October 19, 2023 10:27
FatalError replaced function return because the caller (suricata.c) did not
handle the return value.
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16234

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error messages looking better, imho! :)

@lukashino
Copy link
Contributor Author

continues in #9690

@lukashino lukashino closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants