Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/analyzer: add more details for the tcp seq keyword - v1 #9676

Closed
wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6353

Describe changes:

  • Added the DETECT_SEQ case to the detect-engine-analyzer.c DumpMatches function.
  • Included detect-tcp-seq.h as header file.
SV_BRANCH=https://github.com/OISF/suricata-verify/pull/1435

Log the matched Sequence number of a packet
Issue: OISF#6353
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Oct 22, 2023
@github-actions
Copy link

NOTE: This PR may contain new authors:

Daniel Olatunji <[email protected]>

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, but the commit message is a bit too long.
Can you adjust it to be within the 50-character limit?

Also, as a good practice, as mentioned on the other PR, with changes that alter our output, we prefer to see an output example shared with the PR, please.

Thanks! :)

@0xEniola
Copy link
Contributor Author

The code changes look good to me, but the commit message is a bit too long.
Can you adjust it to be within the 50-character limit?

Thanks! :)

Sure! I just realised.

Thank you for bringing it to my attention.

@0xEniola
Copy link
Contributor Author

The code changes look good to me, but the commit message is a bit too long.
Can you adjust it to be within the 50-character limit?

Also, as a good practice, as mentioned on the other PR, with changes that alter our output, we prefer to see an output example shared with the PR, please.

Thanks! :)

Oh Yeah!

I actually forgot to include an output.
I do know about including output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outreachy Contributions made by Outreachy applicants
Development

Successfully merging this pull request may close these issues.

2 participants