Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verified icon in usernames (rebased) #1480

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Feb 17, 2022

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Rebase from #1205 to pass commit lint whilst keeping original pr ownership

Additional review changes

  • Use new aggregation methods to populate verified
  • Fix unit tests to stub user store as required

Git Issues

Closes #1163

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Feb 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2022

Visit the preview URL for this PR (updated for commit e57a98f):

https://onearmy-next--pr1480-pr-1205-rebased-3-ncc0m1ak.web.app

(expires Thu, 21 Apr 2022 12:57:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@chrismclarke chrismclarke changed the title Pr/1205 rebased 3 feat: verified icon in usernames (rebased) Feb 17, 2022
@cypress
Copy link

cypress bot commented Feb 17, 2022



Test summary

30 1 0 0Flakiness 6


Run details

Project onearmy-community-platform
Status Failed
Commit e57a98f
Started Feb 17, 2022 4:10 PM
Ended Feb 17, 2022 4:17 PM
Duration 06:30 💡
OS Linux Ubuntu - 20.04
Browser Firefox 97

View run in Cypress Dashboard ➡️


Failures

src/integration/sign-up.spec.ts Failed
1 [Sign-up - new user] > sign in as new user

Flakiness

howto/write.spec.ts Flakiness
1 [How To] > [Create a how-to] > [By Anonymous]
2 [How To] > [Create a how-to] > [Warning on leaving page]
3 [How To] > [Edit a how-to] > [By Authenticated]
common.spec.ts Flakiness
1 [Common] > [Not-Found Page]
2 [Common] > [Page Navigation]
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davehakkens davehakkens merged commit 0db1c9a into master Feb 17, 2022
@davehakkens davehakkens deleted the pr/1205-rebased-3 branch February 17, 2022 17:13
@thisislawatts
Copy link
Collaborator

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Events 🎉 Mod: HowTo 📰 Mod: Research 🔬 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display verified icon in username
4 participants