Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update zoom buttons #4068

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the new behavior?

  1. Drops the zoom out/show globe button as it was already getting annoying to maintain.
  2. Updates the zoom in/to user location button to make it clear when a user has already denied a location request.
Screenshot 2025-01-08 at 14 17 21

@benfurber benfurber requested a review from a team as a code owner January 8, 2025 14:21
@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 8, 2025
@benfurber
Copy link
Member Author

@davehakkens I think the location button change here relates to what you were experiencing - location request has already been denied but it wasn't clear that was what had happened.

Copy link

cypress bot commented Jan 8, 2025

onearmy-community-platform    Run #6736

Run Properties:  status check passed Passed #6736  •  git commit 87283f7c1f: feat: drop zoom out button
Project onearmy-community-platform
Branch Review pull/4068
Run status status check passed Passed #6736
Run duration 05m 59s
Commit git commit 87283f7c1f: feat: drop zoom out button
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the feat/map/update-zoom-buttons branch from f68f60d to 87283f7 Compare January 8, 2025 16:52
@benfurber benfurber merged commit 58b3eb9 into ONEARMY:master Jan 8, 2025
17 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Maps 🗺 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants