Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAR 2470 questionnaire picker #3131

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

farres1
Copy link
Contributor

@farres1 farres1 commented Oct 25, 2024

BEFORE MAKING YOUR PR

Please ensure:

  • There are no linting errors, all tests must pass
  • PR is named after JIRA ticket number e.g. EAR-###
  • Accesibility checks are completed:
    • Elements have discernible and consistent focus states
    • Elements can be navigated to and used by just a keyboard
    • Elements and text can be read out by a screen reader, and the descriptions are understandable
  • Your feature / bug fix works across GCP and AWS (where appropriate)
    • Are modifications to eq-publisher-v3 required?
    • Are modifications to the Firestore data source required?

What is the context of this PR?

Updates Author's API to enable questionnaires to be excluded from the questionnaires search page - this enables the currently opened questionnaire to be excluded when selecting a questionnaire to import from, and prevents importing content from the currently opened questionnaire into the same questionnaire.

How to review

Check:

  • The "All questionnaires" and "My questionnaires" pages do not exclude any questionnaires by default
  • The import process' questionnaire picker page excludes the currently opened questionnaire
  • The total number of questionnaires and total page count on the import process' questionnaire picker page exclude the currently opened questionnaire

What to do after everything is green

    • Bring this branch up-to-date with Origin/Master
    • If there are a lot of commits or some are not helpful to read, squash them down
    • Click the Merge button on this pull request
    • Does this change mean the Capability examples questionnaire should be updated?
    • Move the Jira ticket for this task into the next stage of the process

Sorry, something went wrong.

@farres1 farres1 merged commit 220ad87 into master Nov 4, 2024
3 checks passed
@farres1 farres1 deleted the EAR-2470-questionnaire-picker branch November 4, 2024 12:28
@farres1 farres1 added this to the v3.0.49 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants