Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for day_of_week date offset #725

Merged
merged 11 commits into from
Dec 2, 2021
Merged

Add support for day_of_week date offset #725

merged 11 commits into from
Dec 2, 2021

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Nov 24, 2021 •
edited
Loading

What is the context of this PR?

Added support for the day_of_week date offset. Follows the same pattern as the existing date_range_bounds placeholder transform.

How to review

Ensure the changes are appropriate.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@MebinAbraham MebinAbraham mentioned this pull request Nov 24, 2021
Merged
2 tasks
LJBabbage
LJBabbage approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@LJBabbage LJBabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, although I still find it a bit difficult to comprehend, and wonder how easy this will be to implement and explain in Author. However this is not the fault of this PR and does what it is supposed to

@MebinAbraham MebinAbraham merged commit 567f85c into master Dec 2, 2021
@MebinAbraham MebinAbraham deleted the add-day-of-week-date-offset branch December 2, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LJBabbage LJBabbage LJBabbage approved these changes

@petechd petechd petechd approved these changes

@jamesnunn jamesnunn jamesnunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MebinAbraham @jamesnunn @LJBabbage @petechd