Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pr workflow #39

Merged
merged 6 commits into from
May 4, 2021
Merged

Add pr workflow #39

merged 6 commits into from
May 4, 2021

Conversation

JamesGardiner
Copy link
Contributor

@JamesGardiner JamesGardiner commented Apr 27, 2021 •
edited
Loading

What? and Why?

Removes the .travis.yml file
Adds two new Github Actions workflows:

  • pull_request.yaml (run on pull requests to master branch)
  • publish_to_pypi.yaml (run on a release)

Checklist

  • CHANGELOG.md updated? (if required)

@JamesGardiner JamesGardiner marked this pull request as ready for review April 27, 2021 09:34
@pricem14pc pricem14pc self-requested a review April 28, 2021 15:50
@JamesGardiner JamesGardiner force-pushed the migrate-travis-to-gh-actions branch from 88009ac to b272376 Compare April 29, 2021 13:45
pricem14pc
pricem14pc reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the Travis and Codecov badges can come out of the README now

pricem14pc
pricem14pc reviewed Apr 29, 2021
View reviewed changes
setup.py
)
)

with open("./README.md") as fp:
description = fp.read()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does seem to work but I'm not sure how relevant the info is in the Pypi package long description.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In lieu of another long description and the fact it needs a value to suppress the warning it'll probably do. There are other examples in Pypi where the README is simply used here.

@warrenbailey
Copy link
Contributor

LGTM 👍

@JamesGardiner JamesGardiner merged commit c772ff5 into master May 4, 2021
@JamesGardiner JamesGardiner deleted the migrate-travis-to-gh-actions branch May 4, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrenbailey warrenbailey warrenbailey approved these changes

@pricem14pc pricem14pc pricem14pc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesGardiner @warrenbailey @pricem14pc