Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webform_permissions_by_term dependency #22

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

madsnorgaard
Copy link
Contributor

No description provided.

@madsnorgaard madsnorgaard requested a review from andriyun January 14, 2022 12:52
Copy link
Contributor

@andriyun andriyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andriyun andriyun merged commit d0d7574 into develop Jan 14, 2022
@andriyun
Copy link
Contributor

Hi @madsnorgaard
I see that we have a regression after removing this module.
It's active on some our installations.
I'll fix it by adding a module into https://github.com/OS2Forms/os2forms8 project directly.

andriyun added a commit to OS2Forms/os2forms8 that referenced this pull request Jan 25, 2022
 This module still might be used on some installations.
@andriyun
Copy link
Contributor

The webform_permissions_by_term has been added to the general composer list
OS2Forms/os2forms8@dd6d545

stankut added a commit to OS2Forms/os2forms8 that referenced this pull request Nov 22, 2022
* develop:
  Rename main.yml to deploy-release-to-test.yml
  Recreating workflow
  deleting workflow
  changing github action filename
  fixing syntax
  adding mote type to release trigger
  adde release types
  updating script name
  changing rebuild script name
  Adding release publish deploy action
  OS-3 - removing package fixed version
  Adding GIN theme admin toolbar support
  Updated webforms_analysis to Drupal 9
  Updated invalid lock file after merge
  Added module removed from os2forms/os2forms package OS2Forms/os2forms#22 This module still might be used on some installations.
  Updated os2forms to latest release
  Added patch for webform_scheduled_email plugin. See https://www.drupal.org/project/webform/issues/3259195
  Fixed bug with long request_URI in os2web_logging module

# Conflicts:
#	composer.lock
@skifter skifter deleted the remove_webform_permissions_by_term branch January 31, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants