Copy paste NoVNC chrome #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so if clipboard-read permission results in TypeError we just ignore it that way if in the future Firefox or other browser defines clipboard.readText but does not support the read permission we don't get a bunch of console warnings
samirmansour
pushed a commit
that referenced
this pull request
Feb 14, 2020
NoVNC mod for streamlined copy/paste in chrome novnc/noVNC#1301 If clipboard-read permission results in TypeError we just ignore it that way if in the future Firefox or other browser defines clipboard.readText but does not support the read permission we don't get a bunch of console warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198 for Chrome. See issue for summary of solution.
Note: after this is approved, we will need to use our poor-man's cache bust of
noVNC-1.0.0/app.v1.jsby renaming itnoVNC-1.0.0/app.v2.js.