CMake: set rpath to installed plugins on MacOSX frameworks (fixes #4761)

Credits to @PeterPetrik for the hints!
OSGeo · Nov 4, 2021 · 2488e70 · 2488e70
1 parent 3b18f05
commit 2488e70
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/cmake/helpers/GdalDriverHelper.cmake b/cmake/helpers/GdalDriverHelper.cmake
@@ -149,9 +149,21 @@ function(add_gdal_driver)
                               LIBRARY_OUTPUT_DIRECTORY ${PLUGIN_OUTPUT_DIR}
                               SKIP_BUILD_RPATH YES
                               )
+        # The following doesn't work: we have to manually tweak will install_name_tool
+        #if (GDAL_ENABLE_MACOSX_FRAMEWORK)
+        #    set_target_properties(${_DRIVER_TARGET}
+        #                          PROPERTIES
+        #                          INSTALL_RPATH "@loader_path/../../../..")
+        #endif()
         target_link_libraries(${_DRIVER_TARGET} PRIVATE $<TARGET_NAME:${GDAL_LIB_TARGET_NAME}>)
         install(FILES $<TARGET_LINKER_FILE:${_DRIVER_TARGET}> DESTINATION ${INSTALL_PLUGIN_DIR}
                 RENAME "${_DRIVER_TARGET}${CMAKE_SHARED_LIBRARY_SUFFIX}" NAMELINK_SKIP)
+        if (GDAL_ENABLE_MACOSX_FRAMEWORK)
+            file(RELATIVE_PATH relDir
+                 ${CMAKE_CURRENT_BINARY_DIR}/${INSTALL_PLUGIN_DIR}
+                 ${CMAKE_CURRENT_BINARY_DIR}/${FRAMEWORK_DESTINATION})
+            install(CODE "execute_process(COMMAND install_name_tool -add_rpath \"@loader_path/${relDir}\" \"$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/${INSTALL_PLUGIN_DIR}/${_DRIVER_TARGET}${CMAKE_SHARED_LIBRARY_SUFFIX}\")")
+        endif()
         set_property(GLOBAL APPEND PROPERTY PLUGIN_MODULES ${_DRIVER_TARGET})
     else ()
         add_library(${_DRIVER_TARGET} OBJECT ${_DRIVER_SOURCES})

diff --git a/gdal.cmake b/gdal.cmake
@@ -267,7 +267,7 @@ endif ()
 if (GDAL_ENABLE_MACOSX_FRAMEWORK)
   set(CMAKE_MACOSX_RPATH ON)
   set(FRAMEWORK_VERSION ${GDAL_VERSION_MAJOR}.${GDAL_VERSION_MINOR})
-  set(FRAMEWORK_DESTINATION "Library/Frameworks")
+  set(FRAMEWORK_DESTINATION "Library/Frameworks" CACHE STRING "Framework destination sub-directory")
   set(FRAMEWORK_SUBDIR "${FRAMEWORK_DESTINATION}/gdal.framework/Versions/${FRAMEWORK_VERSION}")
   set(INSTALL_PLUGIN_DIR
       "${FRAMEWORK_SUBDIR}/PlugIns"