WFS: Two requests issued for each page

[craigds]

Thanks for the fix in #8654 ! Unfortunately it seems to have introduced a bug...

Expected behavior and actual behavior.

ogr2ogr should issue one request for each page when paginating a WFS datasource.

Instead, it now issues two requests for each page before moving on to the next page:

Steps to reproduce the problem.

$ ogr2ogr -f 'ESRI Shapefile' -sql 'select parcel_pfi, plan_number from "open-data-platform:v_s_parcel_proposed" order by "parcel_pfi"' out.shp 'WFS:https://opendata.maps.vic.gov.au/geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0' 2>&1 | grep CURL_INFO_HEADER_OUT
...
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=0&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=0&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=5000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=5000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=10000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=10000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=15000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
CURL_INFO_HEADER_OUT: GET /geoserver/wfs?REQUEST=GetFeature&SERVICE=WFS&VERSION=2.0.0&TYPENAMES=open%2Ddata%2Dplatform:v_s_parcel_proposed&STARTINDEX=15000&COUNT=5000&SORTBY=parcel_pfi&PROPERTYNAME=parcel_pfi,plan_number HTTP/2
...

Note two requests are issued for each value of STARTINDEX. This seems to be independent of the value of OGR_WFS_PAGE_SIZE

Operating system

MacOS 14.0

GDAL version and provenance

Master build (bug occurs with 7abdaf6 and doesn't occur with a10feb7)