[SQLite] Support SAVEPOINT #11695
Merged
[SQLite] Support SAVEPOINT #11695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement SAVEPOINT for sqlite-based layers
Co-authored-by: Even Rouault <[email protected]>
elpaso
added a commit
to elpaso/QGIS
that referenced
this pull request
Jan 21, 2025
Tell the provider to reload the fields after a rollback and add some checks to verify if after the rollback the provider still needs to update the field. Followup OSGeo/gdal#11695 Followup qgis#59797
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually fixes transactional editing in QGIS for GPKG:
qgis/QGIS#59797 (comment)
Followup #11609
I have also moved the IsGenerated flag to the field definition class as recommended by Even.