Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Point ExprTk to release branch #11716

Merged
merged 1 commit into from
Jan 25, 2025
Merged

CI: Point ExprTk to release branch #11716

merged 1 commit into from
Jan 25, 2025

Conversation

ArashPartow
Copy link
Contributor

Use the release branch instead of the master branch.

@rouault
Copy link
Member

rouault commented Jan 25, 2025

@ArashPartow is there some documentation of the difference between the ExprTk branches: master ,release ? and the logic for tagging. @dbaston was a bit concerned of force pushes that break git history. With stories like https://en.wikipedia.org/wiki/XZ_Utils_backdoor in mind, it is a bit concerning to have funky git practices that make auditing complicated.

@ArashPartow
Copy link
Contributor Author

@rouault release is the stable branch, The master branch may change rapidly and be reverted and have force pushes etc. The tags are only on release and cmake branches.

The tags are semver based making it easier for users that deal in semver style versioning, as ExprTk has its own non-standard versioning which can be found at the bottom of the file.


wrt XZ the changes all happened on master.

@rouault
Copy link
Member

rouault commented Jan 25, 2025

wrt XZ the changes all happened on master.

my point was that force pushes, even on master, are generally frowned upon, as that make reviewing activity quite hard. Anyway that's your project. Thanks for the explanations

@dbaston dbaston merged commit 4622512 into OSGeo:master Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants