added GDALCacheFlushHelperHandler #4852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, when a dataset being processed needs to allocate a new cache block and the global cache is already full, it is not allowed to flush the cache of other datasets to make room in the global cache, in order to prevent problems in multithreading scenarios. This callback asks the user whether it is safe to flush some dataset or not, in order to give a chance to do so and free some cache blocks. By doing so, the pressure on the cache might be released and avoid I/O congestion. It is up to the user to ensure that by answering "yes" in a multithreading scenario, flushing another dataset will not induce unexpected results. This callback cannot be installed on different thread local storages, since its purpose is to get a global answer regarding the user's known current thread states
|
As far as I'm concerned, I don't think this is appropriate for upstream inclusion as discussed in #4762. This is a workaround, hard to use safely and that will cludge the API |
|
I am ok with your position. |
|
I'm closing the PR indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, when a dataset being processed needs to allocate a new cache block
and the global cache is already full, it is not allowed to flush the cache of
other datasets to make room in the global cache, in order to prevent problems
in multithreading scenarios.
The proposed callback of this PR asks the user whether it is safe to
flush some dataset or not, in order to give a chance to do so and free some
cache blocks. By doing so, the pressure on the cache might be released and avoid
I/O congestion. It is up to the user to ensure that by answering "yes" in a
multithreading scenario, flushing another dataset will not induce unexpected results.
This callback cannot be installed on different thread local storages, since its
purpose is to get a global answer regarding the user's known current thread states