Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: Make ogr gpkg tests independent, parallel-safe #8491

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Sep 28, 2023

What does this PR do?

Adds gdaltest.reopen helper
Makes ogr gpkg tests independent, parallel-safe

What are related issues/pull requests?

#4407

Tasklist

  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 67.674% (+0.001%) from 67.673% when pulling 5037410 on dbaston:pytest-independent into bda1424 on OSGeo:master.

@rouault
Copy link
Member

rouault commented Sep 28, 2023

There seem to be a very minor coverage regression at https://coveralls.io/builds/62971018/source?filename=ogr%2Fogrsf_frmts%2Fgpkg%2Fogrgeopackagetablelayer.cpp#L4093 . So a situation where we would call CreateSpatialIndex() on a layer that has no geometry column. That is triggered in master in test_ogr_gpkg_15() with ExecuteSQL("SELECT CreateSpatialIndex('non_spatial', '')")

@dbaston
Copy link
Member Author

dbaston commented Sep 29, 2023

There seem to be a very minor coverage regression at https://coveralls.io/builds/62971018/source?filename=ogr%2Fogrsf_frmts%2Fgpkg%2Fogrgeopackagetablelayer.cpp#L4093 . So a situation where we would call CreateSpatialIndex() on a layer that has no geometry column. That is triggered in master in test_ogr_gpkg_15() with ExecuteSQL("SELECT CreateSpatialIndex('non_spatial', '')")

Restored: https://coveralls.io/builds/62973505/source?filename=ogr%2Fogrsf_frmts%2Fgpkg%2Fogrgeopackagetablelayer.cpp#L4093

@rouault rouault merged commit b929202 into OSGeo:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants