Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default C++ standard to C++17 #8687

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Switch default C++ standard to C++17 #8687

merged 3 commits into from
Nov 14, 2023

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Nov 9, 2023

What does this PR do?

Updates CMakeLists.txt to use C++17 by default.

What are related issues/pull requests?

#8270

Tasklist

  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@dbaston
Copy link
Member Author

dbaston commented Nov 9, 2023

The Windows build is currently failing to build the libkml driver, due to an old version of boost packaged in http://download.gisinternals.com/query.html?content=filelist&file=release-1911-x64-dev.zip trying to use std::auto_ptr:

https://github.com/dbaston/gdal/actions/runs/6811091438/job/18520712504#step:8:2788

@rouault
Copy link
Member

rouault commented Nov 9, 2023

CC @szekerest We are trying to update GDAL C++ version to C++17 and are running in a build issue with the gisinternals.com SDK. The issue is when building the LIBKML driver. libkml depends on boost, and the boost version shipped in gisinternals.com appears to use outdated C++ features like std::auto_ptr which have been removed. Could you try to update the boost version in your SDKs ?

@coveralls
Copy link
Collaborator

coveralls commented Nov 9, 2023

Coverage Status

coverage: 67.869% (-0.004%) from 67.873%
when pulling 1700d0a on dbaston:cpp17
into 170bc25 on OSGeo:master.

Fails to build in C++ due to outdated version of boost
@rouault
Copy link
Member

rouault commented Nov 14, 2023

Could you try to update the boost version in your SDKs ?

filed as gisinternals/buildsystem#221

@dbaston dbaston changed the title Switch default C++ standard to C++17 [WIP] Switch default C++ standard to C++17 Nov 14, 2023
@rouault rouault merged commit 696a72d into OSGeo:master Nov 14, 2023
30 checks passed
@rouault rouault added this to the 3.9.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants