Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEA: fix segfault in CreateCopy with truncated input (fixes #8743) #8786

Closed
wants to merge 2 commits into from
Closed

KEA: fix segfault in CreateCopy with truncated input (fixes #8743) #8786

wants to merge 2 commits into from

Conversation

gillins
Copy link
Contributor

@gillins gillins commented Nov 22, 2023

What does this PR do?

Ensures that all exceptions are handled within KEADataset::CreateLL. Previously only KEAIOException was handled and letting other exceptions bubble up from that function appeared to cause issues.

What are related issues/pull requests?

#8743

Tasklist

  • ADD YOUR TASKS HERE
  • Add test case(s)
  • Add documentation
  • Updated Python API documentation (swig/include/python/docs/)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS:
  • Compiler:

@gillins gillins mentioned this pull request Nov 22, 2023
Closed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 67.908% (+0.003%) from 67.905%
when pulling bbe0fed on gillins:kea_createcopy_segfault
into 4185ffd on OSGeo:master.

@rouault
Copy link
Member

rouault commented Nov 22, 2023

superseded per #8788

@rouault rouault closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gillins @coveralls @rouault