Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV writer: do not quote integer fields by default (only if STRING_QUOTING=ALWAYS is specified) #8813

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 67.916% (+0.004%) from 67.912%
when pulling ca3787b on rouault:csv_output_int_quoting
into fe649a8 on OSGeo:master.

@jratike80
Copy link
Collaborator

What I think was a real problem in the gis.stackexchange case was that the field was defined to be integer in the .csvt file but GDAL did not trust it. Without .csvt it is quite possible that strings like '0123' appear later in the data, but having .csvt indicates that user has taken the responsibility.

@rouault
Copy link
Member Author

rouault commented Nov 24, 2023

What I think was a real problem in the gis.stackexchange case was that the field was defined to be integer in the .csvt file but GDAL did not trust it.

no, the issue in the gis.stackexchange case was only on the writing side. Even if the field was typed as integer, it would be written as quoted.

@jratike80
Copy link
Collaborator

Right, I can see with ogrinfo that the reading side was OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants