Arrow/Parquet: add (minimum) support for libarrow 15.0 #9116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+492
to
499
| #if ARROW_VERSION_MAJOR >= 15 | ||
| case arrow::Type::STRING_VIEW: | ||
| case arrow::Type::BINARY_VIEW: | ||
| case arrow::Type::LIST_VIEW: | ||
| case arrow::Type::LARGE_LIST_VIEW: | ||
| #endif | ||
| case arrow::Type::MAX_ID: | ||
| { |
There was a problem hiding this comment.
Instead of adding every unsupported type explicitly, could you do a default: fallback at the end? Then whenever Arrow adds a new type (that can always happen in the future, and that is also not considered a backwards incompatible change for the format), then the code will still work and by default it would ignore the column? (just as is done now explicitly for those types)
There was a problem hiding this comment.
It is still good to be warned when new types are added, so we are warned that action might be needed...
But in a follow up commit in 35dcdb5 , I've modified the code so that if a new unknown type gets added, a field of that type gets ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.