GPKG: fixes to make most operations compatible with PRAGMA foreign_keys=1 #9141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
reviewed
Jan 25, 2024
| if (m_nPragmaForeignKeysOldValue) | ||
| { | ||
| CPL_IGNORE_RET_VAL( | ||
| SQLCommand(m_poDS->GetDB(), "PRAGMA foreign_keys = 1")); |
There was a problem hiding this comment.
I think there is no need for setting that value back as that is only a connection wide setting. This connection won't be reused outside the geopackage writer, right?
There was a problem hiding this comment.
Maybe it is not expensive to turn it on, and wouldn't it be better to play safe?
There was a problem hiding this comment.
This connection won't be reused outside the geopackage writer, right?
Users of the API could potentially run the GDALDataset::ExecuteSQL("PRAGMA foreign_keys = 1") , so better restore to the setting they used
elpaso
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes #9135)