Doc: OpenFileGDB: document OPENFILEGDB_DEFAULT_STRING_WIDTH configuration option (fixes #9165) #9166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion option (fixes OSGeo#9165)
elpaso
reviewed
Feb 1, 2024
| @@ -664,7 +664,7 @@ int OGROpenFileGDBLayer::BuildLayerDefinition() | |||
| // string width is 0, we pick up 65536 by default to mean unlimited | |||
There was a problem hiding this comment.
this comment needs updates, maybe
Suggested change
| // string width is 0, we pick up 65536 by default to mean unlimited | |
| // string width is 0, if OPENFILEGDB_DEFAULT_STRING_WIDTH is not set we pick up 65536 by default to mean unlimited |
|
I find it confusing that the C++ constant OPENFILEGDB_DEFAULT_STRING_WIDTH and the open option have the same name: if I read this right the first is the hard limit (and the default) and the second is a user-defined default which still needs to be less than the hard limit. |
…xtensive comments
yes, I agree that's confusing. Renamed in an extra commit where I've also added extensive comments to explain the trick |
elpaso
approved these changes
Feb 1, 2024
|
(note: CIFuzz failure is unrelated, and will be addressed per #9181) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.