Identification tunings in TileDB and Shapefile drivers #9170
Conversation
by not identifying /vsi file systems it doesn't handle Relates to conda-forge/tiledb-feedstock#228
| STARTS_WITH_CI(poOpenInfo->pszFilename, "/VSIS3/") || | ||
| STARTS_WITH_CI(poOpenInfo->pszFilename, "/VSIGS/"); | ||
| // If this is a /vsi virtual file systems, bail out, except if it is S3 or GS. | ||
| if (!bIsS3OrGS && STARTS_WITH(poOpenInfo->pszFilename, "/vsi")) |
There was a problem hiding this comment.
is there a reason for not checking case insensitive here too? (assuming that STARTS_WITH and STARTS_WITH_CI are what I think they are regarding case sensitivity).
There was a problem hiding this comment.
Well, the checking for VSIS3 and VSIGS should have been case sensitive from the beginning, but for some reason the original contributor did it case insensitive, so I've kept that check as it in case it was depended upon
| const bool bIsS3OrGS = STARTS_WITH_CI(poOpenInfo->pszFilename, "/VSIS3/") || | ||
| STARTS_WITH_CI(poOpenInfo->pszFilename, "/VSIGS/"); | ||
| // If this is a /vsi virtual file systems, bail out, except if it is S3 or GS. | ||
| if (!bIsS3OrGS && STARTS_WITH(poOpenInfo->pszFilename, "/vsi")) |
|
does this changeset deserve a test? |
the existing tests should be good enough IMHO |
|
@normanb Is there any strong reason for the TileDB driver to support |
Relates to conda-forge/tiledb-feedstock#228