Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE: Allow the project_binary_dir to contain a whitespace #9195

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

weiznich
Copy link
Contributor

@weiznich weiznich commented Feb 5, 2024

What does this PR do?

This PR fixes an issue where installing from a build directory that contains a whitespace fails due to missing path escaping. It's a trivial fix by just escaping the two relevant places.

What are related issues/pull requests?

I did not fill an issue for that, as it seemed easier to just submit this fix.

Tasklist

  • Make sure code is correctly formatted (cf pre-commit configuration)
  • Add test case(s)
  • Add documentation
  • Updated Python API documentation (swig/include/python/docs/)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

Environment

Provide environment details, if relevant:

  • OS: Fedora 39
  • Compiler: GCC 13.2

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 68.801% (-0.001%) from 68.802%
when pulling 2a79606 on GiGainfosystems:cmake_fixes
into 51bf340 on OSGeo:master.

@rouault rouault merged commit 6a768fb into OSGeo:master Feb 5, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants