GDALGetCacheMax64(): fix TSAN complaint (fixes #1837) #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g about lock-order inversion (fixes OSGeo#1108)
elpaso
reviewed
Feb 26, 2024
| pthread_mutex_lock(&global_mutex); | ||
| if (*phMutex == nullptr) | ||
| { | ||
| *phMutex = CPLCreateMutexInternal(true, nOptions); | ||
| bSuccess = *phMutex != nullptr; | ||
| const bool bSuccess = *phMutex != nullptr; |
There was a problem hiding this comment.
are the changes in this file related to the TSAN complaint mentioned above?
On a side note, is there chance we can eventually get rid of in-house mutex handling in favor of std:: library methods?
There was a problem hiding this comment.
are the changes in this file related to the TSAN complaint mentioned above?
not directly, I also incorporated that commit from #1108 because a sanitizer that would test this PR would also frown upon that issue
On a side note, is there chance we can eventually get rid of in-house mutex handling in favor of std:: library methods?
could be a nice cleanup indeed.
elpaso
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.