-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase thread count per gunicorn worker #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
jake-low
force-pushed
the
jlow/increase-parallel-req-limit
branch
from
January 6, 2025 21:02
6c8b541
to
05daee5
Compare
Terraform Format and Style 🖌
|
jake-low
force-pushed
the
jlow/increase-parallel-req-limit
branch
from
January 6, 2025 21:03
05daee5
to
49d1b7e
Compare
Terraform Format and Style 🖌
|
jake-low
added a commit
that referenced
this pull request
Jan 6, 2025
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of running single-threaded gunicorn worker processes, this PR runs 16 threads per worker process. The threads are limited by the Python GIL, so they can't execute in parallel, but this should still increase the number of database queries that can be pending concurrently (since each query ties up the thread that's spawned from until it completes).
This switches gunicorn from using "sync" workers (the default) to "gthread" workers (the default when
--threads
is greater than one). These are entirely different worker implementations, so this change carries some risk. I will monitor it carefully after deploying.