-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting minReadySeconds on the stateful sets #1023
feat: support setting minReadySeconds on the stateful sets #1023
Conversation
This probably needs more work, I couldn't find a suitable test to update. Would appreciate any pointers. |
7545627
to
f582506
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
5685959 | Triggered | Generic Password | 6ce272d | tests/e2e-chainsaw/v1beta2/password/redis-replication/secret.yaml | View secret |
5685959 | Triggered | Generic Password | f5a837f | tests/e2e-chainsaw/v1beta2/ha-setup/secured/partially-secured/replication-password/secret.yaml | View secret |
5685959 | Triggered | Generic Password | f5a837f | tests/e2e-chainsaw/v1beta2/ha-setup/secured/partially-secured/sentinel-password/secret.yaml | View secret |
5685959 | Triggered | Generic Password | c676d3f | tests/e2e-chainsaw/v1beta2/password/redis-cluster/secret.yaml | View secret |
5685959 | Triggered | Generic Password | ee9f5de | tests/e2e-chainsaw/v1beta2/password/redis-cluster/secret.yaml | View secret |
5685959 | Triggered | Generic Password | e474d47 | example/v1beta2/password_protected/secret.yaml | View secret |
5685959 | Triggered | Generic Password | 34a530b | example/v1beta2/password_protected/secret.yaml | View secret |
5685959 | Triggered | Generic Password | c676d3f | tests/e2e-chainsaw/v1beta2/password/redis-replication/secret.yaml | View secret |
5685959 | Triggered | Generic Password | 34a530b | example/v1beta1/password_protected/secret.yaml | View secret |
8742214 | Triggered | Generic Private Key | c38b701 | tests/testdata/secrets/tls.key | View secret |
9242444 | Triggered | Generic Password | c676d3f | tests/e2e-chainsaw/v1beta2/password/redis-standalone/secret.yaml | View secret |
9242444 | Triggered | Generic Password | c676d3f | tests/e2e-chainsaw/v1beta2/password/redis-replication/secret.yaml | View secret |
9242444 | Triggered | Generic Password | c676d3f | tests/e2e-chainsaw/v1beta2/password/redis-cluster/secret.yaml | View secret |
6356333 | Triggered | Generic Password | a3941a4 | example/v1beta2/backup_restore/restore/env-secret.yaml | View secret |
6356333 | Triggered | Generic Password | a3941a4 | scripts/backup/env_vars.env | View secret |
6356333 | Triggered | Generic Password | a3941a4 | scripts/restore/env_vars.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
f582506
to
43afd82
Compare
43afd82
to
969c8d4
Compare
Signed-off-by: Matt Robinson <[email protected]>
969c8d4
to
802f01b
Compare
Found and updated the tests and also updated the examples. Tests pass |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1023 +/- ##
===========================================
+ Coverage 35.20% 46.19% +10.99%
===========================================
Files 19 20 +1
Lines 3213 2704 -509
===========================================
+ Hits 1131 1249 +118
+ Misses 2015 1380 -635
- Partials 67 75 +8 ☔ View full report in Codecov by Sentry. |
Thanks for your contribution. @mattrobinsonsre |
This PR causes backward compatibility problems, like #1030 (comment). We need to set |
Description
minReadySeconds has been standard on stateful sets since v1.25 https://kubernetes.io/blog/2022/09/15/app-rollout-features-reach-stable/#solved-problem-statefulset-minreadyseconds
Configuring it allows one to control the rate at which pods are replaced. This is especially important for a replication+sentinel configuration where there needs to be a reasonable amount of time allowed for the failover processes to complete between pod replacements.
Fixes #1022
feature
Checklist
Additional Context