Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Add the option with_quiet_zone #16

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

OUDON
Copy link
Owner

@OUDON OUDON commented Aug 4, 2022

This PR includes BREAKING CHANGE.

Issue Number

#15

Change

I have add the option with_quiet_zone into below methods.

  • rMQR#to_list
  • rMQR#str

rMQR#to_lsit returns a list with the quiet zone. To return a list without the quiet zone, set False to the option with_quiet_zone. Because the default value of the with_quiet_zone is True, this breaks current behavior.

@OUDON OUDON self-assigned this Aug 4, 2022
@OUDON OUDON marked this pull request as ready for review August 4, 2022 01:17
@OUDON OUDON merged commit 09b11e4 into develop Aug 4, 2022
@OUDON OUDON deleted the feat/add-with-quiet-zone branch August 4, 2022 23:38
@OUDON OUDON restored the feat/add-with-quiet-zone branch August 5, 2022 02:39
@OUDON OUDON deleted the feat/add-with-quiet-zone branch August 5, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant