Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Usage of barrel Imports issue #347

Merged
merged 23 commits into from
Feb 26, 2024
Merged

Update Usage of barrel Imports issue #347

merged 23 commits into from
Feb 26, 2024

Conversation

Uttkarsh-raj
Copy link
Contributor

This pull request fixes #302 . Please review the changes if any needed.

@DonnieBLT DonnieBLT enabled auto-merge February 24, 2024 04:37
@DonnieBLT DonnieBLT disabled auto-merge February 24, 2024 12:58
@DonnieBLT DonnieBLT enabled auto-merge February 24, 2024 17:24
Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update this to work with the localization code that was added recently?

@Uttkarsh-raj
Copy link
Contributor Author

Can you please update this to work with the localization code that was added recently?

Working on it.. by the way i dont know what has happened but the new code pushed is having the following errors...

@Dante291
Copy link
Contributor

take a latest fetch and it will work fine

@Uttkarsh-raj
Copy link
Contributor Author

take a latest fetch and it will work fine

i did but its the same..

auto-merge was automatically disabled February 25, 2024 17:52

Pull request was closed

@Uttkarsh-raj Uttkarsh-raj reopened this Feb 25, 2024
@Uttkarsh-raj
Copy link
Contributor Author

@DonnieBLT i have made the required changes.. Can you review it and tell if there are any other?

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DonnieBLT
Copy link
Collaborator

error • Undefined name 'darkModeProvider' • lib/src/pages/home/issues.dart:54:34 • undefined_identifier

@Uttkarsh-raj
Copy link
Contributor Author

@DonnieBLT the changes have been made and ready to merge with all conflicts resolved...

@DonnieBLT DonnieBLT added this pull request to the merge queue Feb 26, 2024
@DonnieBLT
Copy link
Collaborator

Thank you!

Merged via the queue into OWASP-BLT:main with commit aef5284 Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Update Usage of barrel Imports
3 participants