Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing requirement for Content-Disposition: attachment; filename header #1004

Closed
NeilMadden opened this issue May 25, 2021 · 5 comments
Closed

Consider removing requirement for Content-Disposition: attachment; filename header #1004

NeilMadden opened this issue May 25, 2021 · 5 comments

Comments

@NeilMadden
Copy link
Contributor

Requirement 14.4.2 says:

Verify that all API responses contain a Content-Disposition: attachment; filename="api.json" header (or other appropriate filename for the content type).

It's not clear that this actually prevents any current attack, as RFD attacks are (I believe) prevented by all modern browsers. See also this related issue on the W3C Post-Spectre web development spec.
@elarlang
Copy link
Collaborator

I think this issue is duplicate: #721

@NeilMadden
Copy link
Contributor Author

Quite possibly. I didn’t want to hijack that ticket.

@jmanico
Copy link
Member

jmanico commented May 26, 2021

Neil, it's ok to keep the conversation here. You've given a very clear technical reason why the requirement is not helpful and I'm ready for a PR to remove it. If you PR I'll take care of it and handle the label. We're GTG on this.

@jmanico jmanico mentioned this issue May 26, 2021
Closed
@Bankde
Copy link

Bankde commented May 27, 2021

I'm ok with removing it.

NeilMadden pushed a commit to NeilMadden/ASVS that referenced this issue May 27, 2021
OWASP#1004 Delete 14.4.2 requiring Content-Disposition on API responses
d3d39b2
@NeilMadden NeilMadden mentioned this issue May 27, 2021
Merged
jmanico added a commit that referenced this issue May 27, 2021
@jmanico
Merge pull request #1008 from NeilMadden/remove_content_disposition
88d14f4 
#1004 Delete 14.4.2 requiring Content-Disposition on API responses
@jmanico
Copy link
Member

jmanico commented May 27, 2021

14.4.2 deleted

@jmanico jmanico closed this as completed May 27, 2021
@elarlang elarlang mentioned this issue May 27, 2021
Closed
@tghosth tghosth mentioned this issue Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmanico @NeilMadden @Bankde @elarlang