Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying file download requirements #1458

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Conversation

tghosth
Copy link
Collaborator

@tghosth tghosth commented Dec 20, 2022

This Pull Request relates to issue #1206

@tghosth tghosth linked an issue Dec 20, 2022 that may be closed by this pull request
@tghosth
Copy link
Collaborator Author

tghosth commented Dec 20, 2022

@jmanico what do you think of this modification?

@set-reminder 3 weeks merge if no adverse feedback

@octo-reminder
Copy link

octo-reminder bot commented Dec 20, 2022

Reminder
Tuesday, January 10, 2023 12:00 AM (GMT+01:00)

merge if no adverse feedback

Copy link
Collaborator

@elarlang elarlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion in issue
#1206 (comment)

@elarlang elarlang added _5.0 - prep This needs to be addressed to prepare 5.0 7) PR request changes labels Dec 20, 2022
@tghosth
Copy link
Collaborator Author

tghosth commented Dec 20, 2022

See my response (#1206 (comment)) and updated PR

@jmanico jmanico marked this pull request as ready for review January 2, 2023 23:03
@jmanico jmanico merged commit 72597aa into master Jan 2, 2023
@jmanico jmanico deleted the 1206-1253-grammatical-error branch January 2, 2023 23:03
@octo-reminder
Copy link

octo-reminder bot commented Jan 9, 2023

🔔 @tghosth

merge if no adverse feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

12.5.3 grammatical error
3 participants