Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsiveness of Footer and card component #212

Closed
Rajgupta36 opened this issue Dec 19, 2024 · 15 comments · Fixed by #252
Closed

Fix responsiveness of Footer and card component #212

Rajgupta36 opened this issue Dec 19, 2024 · 15 comments · Fixed by #252
Assignees
Labels
Milestone

Comments

@Rajgupta36
Copy link
Collaborator

Describe the bug

The Card and Footer components are not responsive yet. I want to create a new design for the footer that works well on mobile devices.

Expected Behavior

  • The Card and Footer should be responsive on all screen sizes.
  • Add customization to the Footer for a better mobile design.

Screenshots

Current design of the Card and Footer:

Card Screenshot

Footer Screenshot

@Tusharjamdade
Copy link
Contributor

Hey @Rajgupta36,
I can work on this. I can make the card and footer responsive for all breakpoints (i.e., mobile, tablet, laptop, and so on). Could you please assign it to me?

@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Dec 20, 2024
@arkid15r
Copy link
Collaborator

@Tusharjamdade thank you for helping w/ this. I've assigned it to you as requested.

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Dec 20, 2024
@Tusharjamdade
Copy link
Contributor

Hi @arkid15r @Rajgupta36,
I have redesigned the Header and Footer.
I added a hamburger menu to create a dropdown for small screen devices, such as mobile phones.

Additionally, I redesigned the Footer to make it more responsive for mobile devices. Please let me know if it needs any further improvements.
If everything looks good, I will proceed to open the PR. Thank you!

Nest.Frontend.2.mp4

image

image

@arkid15r
Copy link
Collaborator

Looks cool, thank you @Tusharjamdade
Could you make sure the leaders' avatars look okay too and create a PR?

@Tusharjamdade
Copy link
Contributor

@arkid15r Sorry, what do you mean by "leaders' avatars"? I am not familiar with this term.

@arkid15r
Copy link
Collaborator

@arkid15r Sorry, what do you mean by "leaders' avatars"? I am not familiar with this term.

Technically it's contributors' avatars -- images between Leaders and tags blocks that looks squeezed

image

@Rajgupta36
Copy link
Collaborator Author

Rajgupta36 commented Dec 20, 2024

looks cool, @Tusharjamdade . i also created one design for mobile. can you implement it.
and one small suggestion for hamburger menu . add small animation like when we click it doesn't appear suddenly.
like this dropdown

Recording.2024-12-20.114542.mp4

@Tusharjamdade
Copy link
Contributor

I followed the instructions from OWASP Nest's README, but I am unable to fetch the data. Is there something wrong with my setup, or am I missing something obvious during the setup?

image

image
image

@Tusharjamdade
Copy link
Contributor

looks cool, @Tusharjamdade . i also created one design for mobile. can you implement it. and one small suggestion for hamburger menu . add small animation like when we click it doesn't appear suddenly. like this dropdown

Recording.2024-12-20.114542.mp4

@Rajgupta36 This looks great! I will try to implement it.

@Rajgupta36
Copy link
Collaborator Author

@Tusharjamdade run make load data cmd in root folder
and also use bash terminal

@Tusharjamdade
Copy link
Contributor

Tusharjamdade commented Dec 20, 2024

@Rajgupta36 @arkid15r

image

I am still encountering an error.
The make run command executes successfully, but the error occurs when running make load-data.

@Tusharjamdade
Copy link
Contributor

@arkid15r @Rajgupta36 I think I have an error in my Docker setup. The Nest-backend stopped forcefully.
I tried recloning the repo and setting it up again, but the error still exists.
Can you please help me fix it?

image

@Rajgupta36
Copy link
Collaborator Author

@Rajgupta36 @arkid15r

image

I am still encountering an error.
The make run command executes successfully, but the error occurs when running make load-data.

Pls restore the nest data file which is missing using git restore cmd. Then run

@Tusharjamdade
Copy link
Contributor

Hi @Rajgupta36 @arkid15r,

As mentioned, I have fixed the header, footer, and leaders' avatars, and I have created a pull request.

Thank you for the opportunity!!

Here are some screenshots and screen recordings of the working code.

image

image

Header.and.Card.mp4
Footer.mp4

@Rajgupta36
Copy link
Collaborator Author

nice work @Tusharjamdade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment