-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the responsiveness of the header, footer, and card. #252
Conversation
@arkid15r, Please review the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Couple of things I noticed.
There's this huge gap now above the search component. It's noticeable even on regular page, but on the mobile - it's just crazy big. Can we decrease that to be as it was before?
Some other things:
@kasya, if possible, could you please share a screenshot of it? I am not seeing this on my localhost. |
@kasya, do we need to keep the button next to the labels? It might not look good when there are many labels in the mobile view. Similarly to the Projects page: Alternatively, we could arrange it like this: |
of course!! I was talking about this gap between header and the search component. It's there both on mobile and desctop view now and it wasn't there before: |
I do like this second option more, but only if we are able to keep desktop card as is, where the button is always at the bottom of the card. |
@kasya, we can reduce the number of labels for mobile, but when we expand it (by clicking on the 'Show More' option), the problem still exists, in my opinion. So, which design should we choose? Additionally, I have fixed the header as per the suggestion. The only remaining part is the cards. |
@Tusharjamdade I have implemented the Responsive header #219 with additional functionality. |
@harsh3dev, I have completed the header and footer. The only remaining part is the card. Since you are working on the responsive header as well, as suggested by @kasya, we can take the header from your PR and the footer and card from my PR. |
@Tusharjamdade I don't think you've updated the PR regarding my last comments yet 🤔 I can still see that big gap on the page above the search component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice updates! Left some comments and also pushed small changes to help address some of those!
Also, since we merged in the Responsive header PR there are conflicts now that need to be resolved! 👌🏼
@kasya, I have found a way to reduce the delay, but the overall approach of reducing the number of labels for mobile (i.e., 4 for mobile) remains the same. Should this be fine, or do I need to change the approach? |
@Tusharjamdade I don't see any pushed changes regarding that 🤔 . Only that you've updated your branch with main changes. However, right now, when I check out your branch I can not run it locally due to a incorrect resolved conflicts. The |
@
@kasya, apologies for that. I have now committed the changes to fix the label delay when the page refreshes, and also addressed the double border issue on desktop. |
Hey @Tusharjamdade, thanks for the updates! I reviewed the card and found a few more issues.
I pushed changes to address that. Also, there were a conflict with the Footer that needed to be resolved. Also did that. And lastly, there were many small updates throughout the files, like extra semi-colons etc. Whenever you do that, could you please run I updated everything and this looks good to merge now! Thank you! |
* made header, footer and card responsive * Fix summary layout and adjust leaders/labels alignment on card * fixed some issues with the headers and made the card responsive * fixed the unnecessary escape character error * fixed lucide-react import should occur before import of react error * Add millify package to have human readable numbers for Card meta data * Update Header.tsx * fix: resolve label delay issue after hard refresh * Fix meta data icons in Card component for mobile devices * Fix Footer to work with new centered layout * Apply pre-commit * Apply pre-commit --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Kate <[email protected]>
Resolves #212
Added a hamburger icon for mobile devices to open menu options, implemented a dropdown in the footer for better responsiveness, and fixed the responsiveness of the leaders' avatars. Additionally, made the header sticky at the top and fixed the alignment of the summary and labels, which were aligned to the right in mobile view