Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug: Links not usable #173

Closed
2 tasks done
tilupe opened this issue Oct 9, 2024 · 6 comments · Fixed by #253
Closed
2 tasks done

🐞 Bug: Links not usable #173

tilupe opened this issue Oct 9, 2024 · 6 comments · Fixed by #253
Assignees
Labels
bug Something isn't working

Comments

@tilupe
Copy link

tilupe commented Oct 9, 2024

Before reporting:

  • Ensure that the issue is reproducable on the main branch.
  • Ensure that there isn't an issue on this(either open or closed).

Problem:

When in Reading mode, I can't use any links. Over file links I tried to use Enter () or gf but with Enter I only jump one line and with gf it says it can't find the file "name of the link". Over hyperlinks to websites I tried also gx which won't work either.
Then I tried to enable hybrid-Mode so that I can at least use gf but It didn't change anything for me. I assumed to see the not rendered text on the line I am on. But that was not the case.

Not sure if I missed a command or config that would allow that.

Steps to reproduce the issue:

I just used the default config from the README

Expected behavior:

Links are usable with either "Enter" () or with a configurable keystroke.

Neovim version:

0.10.1

@tilupe tilupe added the bug Something isn't working label Oct 9, 2024
@OXY2DEV OXY2DEV closed this as completed in 4ef3e11 Oct 9, 2024
@OXY2DEV
Copy link
Owner

OXY2DEV commented Oct 9, 2024

You can use this to open links,

:MarkOpen

Or use gx.

@tilupe
Copy link
Author

tilupe commented Oct 9, 2024

You can use this to open links,

:MarkOpen

Or use gx.

Thank you so much! and it is amazing how fast you responed. It works perfectly for web-links. One question: Did you intend that for file-links I should use another plugin? (I saw that there exists some e.g. https://github.com/jghauser/follow-md-links.nvim) Since it could be not trivial to solve it.
When I use :MarkOpen on a file-link it will opens the file in a text editor.

@OXY2DEV
Copy link
Owner

OXY2DEV commented Oct 9, 2024

When I use :MarkOpen on a file-link it will opens the file in a text editor.

It will open the file in whatever you set your default app for.

Did you intend that for file-links

I didn't really do any extra implantation. Whatever is opened is determined by Neovim.

But I do plan on supporting internal links(from obsidian), ID links and opening text files inside Neovim.

@AndreM222
Copy link

AndreM222 commented Oct 9, 2024

Thanks brother

@UtkarshVerma
Copy link

The current latest release v24.0.0 doesn't have this. I see the readme mentioning v25.0.0 as the latest version which isn't the case. @OXY2DEV Did the release pipeline fail?

OXY2DEV added a commit that referenced this issue Nov 23, 2024
@OXY2DEV
Copy link
Owner

OXY2DEV commented Nov 23, 2024

The current latest release v24.0.0 doesn't have this. I see the readme mentioning v25.0.0 as the latest version which isn't the case. @OXY2DEV Did the release pipeline fail?

That's just me commiting to the wrong branch.

OXY2DEV added a commit that referenced this issue Jan 4, 2025
Use `:Markview open` instead.

Ref: #173

feat: Added more link type support for opening links.

Also adds `email` support.

Ref: #177
OXY2DEV added a commit that referenced this issue Jan 10, 2025
Use `:Markview open` instead.

Ref: #173

feat: Added more link type support for opening links.

Also adds `email` support.

Ref: #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants