Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash when no model settings defined #223

Closed
sambles opened this issue Apr 16, 2020 · 1 comment · Fixed by #263
Closed

App crash when no model settings defined #223

sambles opened this issue Apr 16, 2020 · 1 comment · Fixed by #263
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sambles
Copy link
Contributor

sambles commented Apr 16, 2020

Example Model_settings file

Download
{
  "model_settings": {},
  "lookup_settings": {
    "supported_perils": [
      {
        "id": "QEQ",
        "desc": "Single Peril: EarthQuake only"
      }
    ]
  }
}

The above causes a crash at the output configuration step

In Login User:  admin
Authenticated
.hideDivs step3 called
.hideDivs step1 called
.defaultCreateProg called
.reloadtbl_portfoliosData called
portfolio table refreshed
.hideDivs step2 called
.reloadAnaData step2 called
.reloadAnaData landingpage called
replacing icons
analyses table refreshed
Navigate to Landing Page
Navigate to Define Single Analysis
re-rendering portfolio table
input$dt_Portfolios_rows_selected is changed to: 1
updating portfolioID because selection in portfolio table changed to 15
updating result$portfolioID because submodulesList$step1_choosePortfolio$portfolioID() changed to: 15
updating input$portfolioID because result$portfolioID changed to: 15
.hideDivs step2 called
.reloadAnaData step2 called
replacing icons
analyses table refreshed
.hideDivs step1 called
.hideDivs step2 called
.hideDivs step3 called
.defaultstep3 called
.reloadAnaData step3 called
replacing icons
analyses table refreshed with 1 rows
showing Section 'Configure Output & Run' = '3'
input$dt_analyses_rows_selected is changed to: 
re-rendering analysis table
updating output parameters for Summary configuration and cleaning up UI
.clearOutputOptions called
replacing icons
input$dt_analyses_rows_selected is changed to: 1
analysisId changed to 15
.clearOutputOptions called
replacing icons
showing panelDefineOutputs
.gen_analysis_settings called
replacing icons
Warning: Error in <-: 'names' attribute [2] must be the same length as the vector [0]
  75: fetch_model_settings
  74: .gen_analysis_settings
  73: observeEventHandler
   2: runApp
   1: oasisui::runOasisui

@sambles sambles added the bug Something isn't working label Apr 16, 2020
@sambles sambles changed the title App crash if when no model settings defined App crash when no model settings defined May 13, 2020
@nfarabullini nfarabullini self-assigned this Sep 24, 2021
nfarabullini pushed a commit that referenced this issue Oct 6, 2021
changes for issue #223 required edits implemented
@sambles sambles linked a pull request Dec 6, 2021 that will close this issue
sambles added a commit that referenced this issue Dec 6, 2021
* changes for issue #228
changes for issue #223 required edits implemented

* added number of samples to teh analysis settings
number of samples is retrieved from analysis settings in step 3
minor adjustments

* fix to pop up tooltip

* replaced "Model Values" table with set of tabs

* small bug fix
restored correct package versions

* added functionality for single tab in model values in case no parameters_group is available

* fixed list parameters rendering
adjusted number of characters limit in tooltip box

* adjusted list format

* updates for locnumbers e.g. "1-"

* fixes for exposure validation map

* clean up for validation map

* update to buildcustom

* merging of data files for exposure validation map

* Update analysis setting names (#265)

Co-authored-by: sambles <[email protected]>
@awsbuild awsbuild added this to the 1.11.0 milestone Dec 6, 2021
@nfarabullini
Copy link
Contributor

closed with PR #263

@awsbuild awsbuild modified the milestones: 1.11.0, 1.11.1 Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants