Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/analysis settings bug #274

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Hotfix/analysis settings bug #274

merged 2 commits into from
Dec 21, 2021

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Dec 21, 2021

Fixed bug in the complex model workflow

The analysis settings field was not set correcting in both versions 1.11.0 and 1.10.0

  • Bug in 1.11.0 - the model_name_id was set as the API model reference ID and would cause the anaysis_settings post to fail with Bad Request 400
  • Bug in 1.10.0 - the model_version_id field was set with the wrong value, passing that to a complex model would cause the custom binary search to fail.

@sambles sambles linked an issue Dec 21, 2021 that may be closed by this pull request
@sambles sambles merged commit 34e9b40 into develop Dec 21, 2021
@sambles sambles deleted the hotfix/analysis_settings_bug branch December 21, 2021 16:41
@awsbuild awsbuild added this to the 1.11.1 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

analysis_settings generation is incorrectly setting 'model_name_id'
2 participants