Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libQGLViewer detection is broken #225

Open
yurivict opened this issue Nov 20, 2018 · 2 comments
Open

libQGLViewer detection is broken #225

yurivict opened this issue Nov 20, 2018 · 2 comments

Comments

@yurivict
Copy link

yurivict commented Nov 20, 2018

Without QGLVIEWER_BASE_DIR is begins to build the bundled libQGLViewer.
When QGLVIEWER_BASE_DIR is specified but QGLViewer_LIBRARY_DIR_OTHER isn't, it doesn't build libQGLViewer and just skips the viewer altogether, which doesn't make sense.

Please note that nowadays all systems have libQGLViewer: https://repology.org/metapackage/libqglviewer/versions

Suggested solution: remove the bundled libQGLViewer and require both QGLVIEWER_INCLUDE_DIR and QGLVIEWER_LIB_DIR in order to use the external package.

@ahornung
Copy link
Member

Good point. Any chance for a pull request / patch contribution?

@yurivict
Copy link
Author

I really don't have resources to fix individual projects that I don't even use.
Normally this is the project maintainers' responsibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants